worker: simplify response check#384
Open
mistydemeo wants to merge 1 commit intointernetarchive:masterfrom
Open
worker: simplify response check#384mistydemeo wants to merge 1 commit intointernetarchive:masterfrom
mistydemeo wants to merge 1 commit intointernetarchive:masterfrom
Conversation
mistydemeo
force-pushed
the
misty/simplify_mime_type_check
branch
from
0327bed to
f07a9d2
Compare
Pre-fetching this with .get() calls lets us skip some repetitive indexing.
mistydemeo
force-pushed
the
misty/simplify_mime_type_check
branch
from
f07a9d2 to
8f5d0ba
Compare
Contributor
|
This is a nice change, why it hasn't been merged yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a minor tweak - when reading this I found the repeated indexing and
a in bchecks harder to read, so I figured safely grabbing the data at the start would let us shorten the rest of the logic.